Skip to content

Add CI workflow to check for problems with npm configuration files #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2022
Merged

Add CI workflow to check for problems with npm configuration files #60

merged 1 commit into from
Dec 20, 2022

Conversation

MatteoPologruto
Copy link
Contributor

On every push and pull request that affects relevant files, and periodically:

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Dec 20, 2022
@MatteoPologruto MatteoPologruto self-assigned this Dec 20, 2022
@MatteoPologruto
Add CI workflow to check for problems with npm configuration files
19b6bb9 
On every push and pull request that affects relevant files, and periodically:

- Validate package.json against its JSON schema.
- Check for forgotten package-lock.json syncs.
per1234
per1234 requested changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pull in the latest change from the upstream repo so it will be all up to date:

arduino/tooling-project-assets@bc3a0e3#diff-e7c934c4d9a9ce5aac13b9fb768cb1503b90d239c8de3411f44cc6f2a6614c19

per1234
per1234 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matteo!

@MatteoPologruto MatteoPologruto merged commit 64e2156 into arduino:master Dec 20, 2022
@MatteoPologruto MatteoPologruto deleted the check-npm branch December 20, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@umbynos umbynos Awaiting requested review from umbynos

Assignees

@MatteoPologruto MatteoPologruto

Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatteoPologruto @per1234